Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifier] Reformat the tables that list the service integrations #20667

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

javiereguiluz
Copy link
Member

We did this for the SMS services, but let's do it for the others too (e.g. I need it to fix #20662).

@javiereguiluz
Copy link
Member Author

I can't understand why this is failing. I need help, please.

notifier.rst Outdated
Comment on lines 678 to 681
=============== ================================================================
`JoliNotif`_ **Install**: ``composer require symfony/joli-notif-notifier`` \
**DSN**: ``jolinotif://default``
=============== ================================================================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=============== ================================================================
`JoliNotif`_ **Install**: ``composer require symfony/joli-notif-notifier`` \
**DSN**: ``jolinotif://default``
=============== ================================================================
============= ================================================================
`JoliNotif`_ **Install**: ``composer require symfony/joli-notif-notifier`` \
**DSN**: ``jolinotif://default``
============= ================================================================

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted this change because I cannot make it work. Maybe it's some edge-case because this is a single row table.

@javiereguiluz javiereguiluz merged commit 99fce48 into symfony:7.2 Feb 19, 2025
1 check passed
@javiereguiluz javiereguiluz deleted the tweak_notifier branch February 19, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants